-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move font specification into global variables #23
Conversation
Also improved documentation
Hold off on merging this for now. I think I've found a solution allowing the specification of a backup font that I will try to add to this. |
Never mind, the solution I thought I found turned out to be unreliable. :( Please review the code and merge. |
This appears to contain both font-fix AND label_last_point related changes. Is this meant to be both? The font-fix aspects look great, but I do have some questions about the label_last_point feature. |
What questions? The bulk of the label-last-point functionality got merged into master accidentally a week or two ago because GitHub's desktop app forced me into doing that when I was merging master into label-last-point. The only code unrelated to fixing fonts in this PR is some extra documentation. |
Ah, forgot about that. Questions about label_last_point mostly pertain to implicitly automating behavior that the user is likely to need pretty much every time this function is added. Of course, this means more work now, and it may be that some of these things are not worth the effort. But here's what comes to mind:
Label in topline aes:
label in secondary aes:
|
updated the above comment a moment ago to correct display error in code blocks. |
I created a new issue (#24) with your suggestions. They don't relate to fonts and should be kept separate from this PR. |
Also improved documentation