New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revolution slider compatibility #1110
Comments
Do you have a |
What is the full url to the |
Hi, I'm also getting the same issue, is there any suggestion on where is the problem ? Either Revolution or CMB2 Need to fix the problem ? Thank you. |
@pareshsojitra can you confirm questions asked by justin in #1110 (comment) ? |
+1 for this problem. what should happen to you to eliminate this problem? |
@MyLoVeSunITy works for me in remove |
It causes trouble also with Wp Export and Wp All import plugins from www.wpallimport.com If you comment out this code /wp-content/plugins/cmb2/includes/CMB2_JS.php line: 234 Everything works again. |
I realize i'm going to come off pointing fingers, but unless CMB2 is somehow using this function wrong, or storing the return results wrong, then it's more an issue coming from these other plugins. They need to also be made aware of the errors coming up from someone potentially using a core WordPress function in these various screens. Specifically I'm willing to be wrong though, don't get me wrong, but the found "solution" is just removing a newly added feature for CMB2. |
|
Logically, limiting where possible makes total sense, but the question ends up being how to do that successfully, when CMB2 can be added to both post editor screens as well as term editor screens. All of which may have these other libraries/plugins included as well. We could check, if not done already, if there's a field type that uses this codemirror lib before adding, however once there is, the same conflict is potentially going to show up. There still needs to be compatibility resolution from these other items as well. |
2.4.2 addresses this issue and only enqueues WP's code editor functionality if a |
Thank you so much for your fixes |
That being said, like Michael said, this conflict only partially mitigates the issue.. The version of code mirror in core is the one that all plugins need to be using to avoid conflicts. Please spread the word to those other plugins. |
Latest development version causes Revolution slider plugin not to work. The WordPress.org version of CMB2 works fine. When i updated to the latest version, this is the error the slider reports:
Rev slider is not really a codebeauty masterpice, so it is quite possible the problem is on their end.
As soon as I switch to the old CMB2, this error is gone.
Anyway, I just wanted to let you know about this issue.
The text was updated successfully, but these errors were encountered: