Fixes PHP warnings on repeatable ColorPicker with an array as default

[rubengc]

This PR fixes PHP warnings when setting up a ColorPicker field as repeatable and passing as default parameter an array caused by pass this array to preg_match() and trim() functions

Basically, this doesn't causes any error, just PHP warnings that would be awesome to silence

Check issue #1285 where everything gets explained

Fixes #1285
Fixes #1286

[tw2113]

I'd honestly prefer that the actual errors got addressed instead of just silencing them here.

[jtsternberg]

I agree, I think there's a better way to ensure compatibility than telling it to shut up. :)

[rubengc]

Which way do you prefer?

Checking if is an array, getting only the first value like this:

if( is_array( $meta_value ) ) {
    $meta_value = $meta_value[0]
} 

Or, only applying sanitization if is a string only:

	if( gettype( $meta_value ) === 'string' ) {
		$hex_color = '(([a-fA-F0-9]){3}){1,2}$';
		if ( preg_match( '/^' . $hex_color . '/i', $meta_value ) ) {
			// Value is just 123abc, so prepend #
			$meta_value = '#' . $meta_value;
		} elseif (
			// If value doesn't match #123abc...
			! preg_match( '/^#' . $hex_color . '/i', $meta_value )
			// And value doesn't match rgba()...
			&& 0 !== strpos( trim( $meta_value ), 'rgba' )
		) {
			// Then sanitize to just #.
			$meta_value = '#';
		}
	}

[rubengc]

Ah, I forgive to mention here that this issue only happens on the empty field generated by the repeatable field

The empty field is the field used as pattern every time the field gets repeated

[jtsternberg]

Best would be a new method for the sanitization, and send the meta value into the method, or do array_map to loop through the array to sanitize.

[rubengc]

Ready!

[tw2113]

Can you resolve the conflicts coming up in the PR here?

[jtsternberg]

Left a few suggestions. Have you tested this with a normal color picker and repeatable?

[rubengc]

Tested with both fields and everything works perfectly

The unique issue I found is an "array to string conversion" error from the CMB2_Utils concat_attrs() function:
https://github.com/CMB2/CMB2/blob/develop/includes/CMB2_Utils.php#L584-L599

I added on this PR a change checking if is an array, turn it into a comma-separated list of values:
42bcb97

[tw2113]

the PR is still showing some conflicts in CMB2_Type_Colorpicker.php file here in GitHub's UI.

[jtsternberg]

Get these changes in (and merge develop into this branch and fix merge conflict), and I think it's ready to go.

[rubengc]

All conflicts resolved, can this get added to CMB2?

[rubengc]

could this one get merged? Changes requested have been added yet

[jtsternberg]

Thank you!