add a phpcompatibility action #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not entirely sure if the 8.0+ check will work but we'll see
jtsternberg
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a PHP Compatibility action to that validates against PHPCompatibility
Motivation and Context
Should alert in the future if any change is not compatible with the latest PHP version. Will need to be updated for PHP 8.3, 8.4, 9.0, etc.
Risk Level
minimal risk -- this only runs in the repository. The potential gain is big, though, because it should, in theory, catch any PHP compatibility issues.
I'm somewhat suspicious of the passing tests now, however, because it seems like they may be false positives, but with the action in place and set, issues can be reported to https://github.com/pantheon-systems/phpcompatibility-action/issues if it seems like we're not getting appropriate flagging.
Testing procedure
Self-testing. This PR is, itself, a test. 馃榾
Types of changes
New feature (GH action)
Checklist: