Non-Repeatable Groups - Issue/93 #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcusbattle can you merge master into your branch as it's pretty far out of date. |
|
Sure thing! On Tue, Jan 27, 2015 at 4:11 PM, Justin Sternberg notifications@github.com
|
|
Hey Justin, my branch has been updated. Let me know if you need anything else. |
|
I think this could be simplified further looking at it (also just ran into needing a non repeatable group). Passing |
jtsternberg
added a commit
that referenced
this pull request
May 4, 2015
|
Finally got this feature merged. I made a few updates/tweaks (things like @pmgarman mentioned). You can see all the changes here: 0d3f706...6350d5e |
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this pull request
May 29, 2015
* Ability to use non-repeatable group fields by setting the `'repeatable'` field param to `false` when registering a group field type. Props [marcusbattle](https://github.com/marcusbattle), ([#159](CMB2/CMB2#159)). * Add and enqeueue a front-end specific CSS file which adds additional styles which are typically covered by wp-admin css. ([#311](CMB2/CMB2#311)) * Better handling of the CMB2 javascript (and CSS) required dependencies array. Dependencies are now only added conditionally based on the field types that are actually visible. ([#136](CMB2/CMB2#136)) * **THIS IS A BREAKING CHANGE:** The `group` field type's `'show_on_cb'` property now receives the `CMB2_Field` object instance as an argument instead of the `CMB2` instance. If you're using the `'show_on_cb'` property for a `group` field, please adjust accordingly. _note: you can still retrieve the `CMB2` instance via the `cmb2_get_metabox` helper function._ * New dynamic hook, `"cmb2_save_{$object_type}_fields_{$this->cmb_id}"`, to complement the existing `"cmb2_save_{$object_type}_fields"` hook. * New CMB2 property, `enqueue_js`, to disable the enqueueing of the CMB2 Javascript. * German translation provided by Friedhelm Jost. ### Bug Fixes * Fix incorrect repeatable group title number. ([#310](CMB2/CMB2#310)) * Fix obscure bug which prevented group field arguments from being passed to the sub-fields (like `show_names` and `context`). * Fixed occasional issue when adding a group row, the previous row's content would be cloned. ([#257](CMB2/CMB2#257)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1169742 b8457f37-d9ea-0310-8a92-e5e31aec5664
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this pull request
May 29, 2015
* Ability to use non-repeatable group fields by setting the `'repeatable'` field param to `false` when registering a group field type. Props [marcusbattle](https://github.com/marcusbattle), ([#159](CMB2/CMB2#159)). * Add and enqeueue a front-end specific CSS file which adds additional styles which are typically covered by wp-admin css. ([#311](CMB2/CMB2#311)) * Better handling of the CMB2 javascript (and CSS) required dependencies array. Dependencies are now only added conditionally based on the field types that are actually visible. ([#136](CMB2/CMB2#136)) * **THIS IS A BREAKING CHANGE:** The `group` field type's `'show_on_cb'` property now receives the `CMB2_Field` object instance as an argument instead of the `CMB2` instance. If you're using the `'show_on_cb'` property for a `group` field, please adjust accordingly. _note: you can still retrieve the `CMB2` instance via the `cmb2_get_metabox` helper function._ * New dynamic hook, `"cmb2_save_{$object_type}_fields_{$this->cmb_id}"`, to complement the existing `"cmb2_save_{$object_type}_fields"` hook. * New CMB2 property, `enqueue_js`, to disable the enqueueing of the CMB2 Javascript. * German translation provided by Friedhelm Jost. ### Bug Fixes * Fix incorrect repeatable group title number. ([#310](CMB2/CMB2#310)) * Fix obscure bug which prevented group field arguments from being passed to the sub-fields (like `show_names` and `context`). * Fixed occasional issue when adding a group row, the previous row's content would be cloned. ([#257](CMB2/CMB2#257)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1169744 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Justin, here's the updates for issue 93. I'm not sold on the dom and how to modify the CSS so I could use your help there, but the base logic for non-repeatable fields is present.