Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sassify! #18

Merged
merged 2 commits into from Aug 30, 2014

Conversation

@gregrickaby
Copy link
Contributor

commented Aug 26, 2014

I'm going to properly sassify CMB2 馃憤

@jtsternberg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2014

No better man for the job! Hate to ask, but is this all tested?

@jtsternberg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2014

Also, what is the update_submodules task/grunt plugin for? We don't have any submodules in CMB.

@gregrickaby

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2014

Ah, that's my bad on the submodules. I thought that kept NODE MODULES updated... I'll remove it.

@jtsternberg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2014

Maybe it does? I don't know. :)

@gregrickaby

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2014

If by tested you mean, do the styles look the same as CMB2/master? Then the answer is yes.

I tried to keep the CSS identical to what you had. However, I did make some minor color tweaks to keep things consistent (was there really a need for 2 or 3 different "light yellows")?

And it looks like it does keep GIT submodules current, not Node modules. https://github.com/jaubourg/grunt-update-submodules

@jtsternberg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2014

Yah, that's pretty much what I mean. BUT CMB can be used in the post metaboxes, as a settings page, as user fields, and not to mention the front-end. so If we're going to make big changes to the css, we need to at least look at CMB in all those contexts, as well as viewing each field type. Does that make sense?

@jtsternberg jtsternberg merged commit 3818952 into CMB2:master Aug 30, 2014

@jtsternberg

This comment has been minimized.

Copy link
Member

commented Aug 30, 2014

馃挜 Thanks @gregrickaby
selfie-2

@gregrickaby gregrickaby deleted the gregrickaby:sassify branch Aug 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.