Resolve issue with hiding field names

[mustardBees]

Hide field names unless they're titles.

[mustardBees]

I've read the contributing document now... I can resubmit to trunk if the fix is suitable?

[jtsternberg]

Thanks Phil, and nice catch! After we get out of beta, we'll switch to master/trunk, but for now, it's all on master.

[jtsternberg]

I actually had to roll this change back as it was causing the unit tests to fail. Can you provide the scenarios which your patch is meant to fix? In other words, describe what is broken, and how your PR fixes it.

[mustardBees]

See the example below, with 'show_names' => false, I would expect the field headings to be hidden.

Example metabox

/**
 * Metabox to store listing information
 */
$meta_boxes['listing_information_meta_box'] = array(
    'id' => 'listing_information_meta_box',
    'title' => 'Listing Information',
    'object_types' => array( 'listing' ), // post type
    'context' => 'side',
    'priority' => 'low',
    'show_names' => false, // Show field names on the left
    'fields' => array(
        array(
            'name' => 'Address',
            'id' => $prefix . 'address',
            'type' => 'textarea_small',
        ),
        array(
            'name' => 'Telephone',
            'id' => $prefix . 'telephone',
            'type' => 'text',
        ),
    ),
);

Result

The patch simply swaps the logic around so that field headings are hidden unless the field type is title.

[jtsternberg]

Ok, makes sense. There was a bit more work involved with fixing this default behavior, but it should be good to go now.

[mustardBees]

Thanks and keep up the good work!