Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese translation pt_PT according Language Team Guidelines #727

Merged
merged 2 commits into from Sep 6, 2016

Conversation

pedro-mendonca
Copy link
Contributor

Fixes #709.

Changes proposed in this pull request

Question: Will this translation be overriden by future Transifex imports?
Note: The translation being imported from Transifex is incomplete and isn't according pt_PT Translation Team Translation Guidelines. We are maintaining this branch and translation as the only way to keep a correct translation, discussed and according the WP core and themes/plugins translation guidelines for our locale.

@jtsternberg
Copy link
Member

Thank you for this submission, and thank you @alvarogois for #709. Now that I understand a bit more about the nuances of translations from wp.org, it will be my goal not to override translations provided through that process. Are the translations provided here, the same as those on wp.org? Because I cannot guarantee that the translations here will not be stomped from the translations on wp.org.

@jtsternberg jtsternberg merged commit ad2524c into CMB2:trunk Sep 6, 2016
jtsternberg added a commit that referenced this pull request Sep 6, 2016
@pedro-mendonca
Copy link
Contributor Author

pedro-mendonca commented Sep 6, 2016

Hi @jtsternberg

The stable version of the strings of CMB2 isn't still available at the wp.org repository.

The translation we've pushed here will be exactly the same that will be at wp.org as soon as it's available. When I find an error or add new strings, I usually update it on both wp.org and github (if they exist on both).
For now, it's synced only with Development branch.

As this CMB2 case it's a bit different from other cases, as @alvarogois mentioned, the situation of having it bundled as a module, it's probably a good practice to keep the .po files also in github.
If you'll make the Stable translation set available on wp.org, you'll probably have to think on a way to sync it all, but you'll need translation editors on every language that CMB2 is translated.

It currently gets a little messy with 3 platforms, GitHub, wp.org and Transifex. It's a pain to choose wich one gets priority, or even per language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants