Skip to content

Commit

Permalink
Feature/improved help (#81)
Browse files Browse the repository at this point in the history
* adding list bookings module

* adding `list_requests` parser

* adding `show_inbox` parser

* adding a `logout` parser

* adding `prog` arg to parsers

* improving test coverage

* improving docstrings

* making `help_<command>` methods `@staticmethod`

* fixing potential arg errors

* making help method static
  • Loading branch information
nklapste committed Nov 5, 2018
1 parent 18eff50 commit 8d3230e
Show file tree
Hide file tree
Showing 14 changed files with 242 additions and 102 deletions.
4 changes: 3 additions & 1 deletion mini_project_1/book_member.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@

def get_book_member_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="book_member",
add_help=False,
description="Book a member on a ride")

parser.add_argument("email",
help="Email of the member who will be booked on the ride")
help="Email of the member who will be booked on "
"the ride")
parser.add_argument("seats", type=greater_than_zero_number,
help="The number of seats booked")
parser.add_argument("price", type=price,
Expand Down
1 change: 1 addition & 0 deletions mini_project_1/cancel_booking.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def get_cancel_booking_parser() -> ShellArgumentParser:
"""Get a :class:`ShellArgumentParser` for use in parsing the arguments
for a ``cancel_booking`` command"""
parser = ShellArgumentParser(
prog="cancel_booking",
add_help=False,
description="Cancel a booking")

Expand Down
1 change: 1 addition & 0 deletions mini_project_1/delete_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

def get_delete_request_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="delete_request",
add_help=False,
description="Delete a ride request by rid")

Expand Down
19 changes: 19 additions & 0 deletions mini_project_1/list_bookings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#!/usr/bin/python
# -*- coding: utf-8 -*-

"""List bookings
The member should be able to list all bookings on rides s/he offers.
"""

from mini_project_1.common import ShellArgumentParser


def get_list_bookings_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="list_bookings",
add_help=False,
description="List all the bookings that you offer")

return parser

19 changes: 19 additions & 0 deletions mini_project_1/list_requests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#!/usr/bin/python
# -*- coding: utf-8 -*-

"""List requests
The member should be able to see all his/her ride requests.
"""

from mini_project_1.common import ShellArgumentParser


def get_list_ride_requests_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="list_requests",
add_help=False,
description="List all the ride requests that you offer")

return parser

15 changes: 15 additions & 0 deletions mini_project_1/logout.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/usr/bin/python
# -*- coding: utf-8 -*-

"""Logout functionality"""

from mini_project_1.common import ShellArgumentParser


def get_logout_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="logout",
add_help=False,
description="Logout to the mini-project-1 database")

return parser
1 change: 1 addition & 0 deletions mini_project_1/offer_ride.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

def get_offer_ride_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="offer_ride",
add_help=False,
description="Offer a ride")

Expand Down
1 change: 1 addition & 0 deletions mini_project_1/post_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def get_post_request_parser() -> ShellArgumentParser:
"""Get a :class:`ShellArgumentParser` for use in parsing the arguments
for a ``post_ride_request`` command"""
parser = ShellArgumentParser(
prog="post_request",
add_help=False,
description="Post a ride request")

Expand Down
2 changes: 2 additions & 0 deletions mini_project_1/search_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

def get_search_requests_lcode_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="search_requests_lcode",
add_help=False,
description="Search ride requests by location code")

Expand All @@ -26,6 +27,7 @@ def get_search_requests_lcode_parser() -> ShellArgumentParser:

def get_search_requests_city_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="search_requests_city",
add_help=False,
description="Search ride requests by city name")

Expand Down
1 change: 1 addition & 0 deletions mini_project_1/search_rides.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

def get_search_for_ride_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="search_rides",
add_help=False,
description="Search for a ride and if one is selected sent a message "
"of intent to join")
Expand Down
1 change: 1 addition & 0 deletions mini_project_1/select_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

def get_select_request_parser() -> ShellArgumentParser:
parser = ShellArgumentParser(
prog="select_request",
add_help=False,
description="Select a ride request and perform actions with it"
)
Expand Down

0 comments on commit 8d3230e

Please sign in to comment.