Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: browse page can search for books #115

Merged
merged 4 commits into from
Nov 14, 2020
Merged

feat: browse page can search for books #115

merged 4 commits into from
Nov 14, 2020

Conversation

c25vdw
Copy link
Contributor

@c25vdw c25vdw commented Nov 12, 2020 •
edited
Loading

  • do we need to be case-insensitive?

@c25vdw
Copy link
Contributor Author

c25vdw commented Nov 12, 2020

demo

output10

zhpeng811
zhpeng811 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@zhpeng811 zhpeng811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just two minor comments

app/src/main/java/com/cmput301f20t21/bookfriends/ui/browse/BrowseFragment.java Outdated Show resolved Hide resolved
app/src/main/java/com/cmput301f20t21/bookfriends/ui/browse/BrowseViewModel.java Outdated Show resolved Hide resolved
kdvuong
kdvuong approved these changes Nov 14, 2020
View reviewed changes
Copy link
Contributor

@kdvuong kdvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments but overall lgtm.
Your implementation of search is exactly what I mean in #112 .

This was linked to issues Nov 14, 2020
US 03.02.01: As a borrower, I want search results to show each book with its description, owner username, and status. #40
Closed
US 03.01.01: As a borrower, I want to specify a keyword, and search for all books that are not currently accepted or borrowed whose description contains the keyword. #41
Closed
@c25vdw c25vdw merged commit 7ff0602 into master Nov 14, 2020
@c25vdw c25vdw deleted the search-available-books branch November 14, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdvuong kdvuong kdvuong approved these changes

@zhpeng811 zhpeng811 zhpeng811 approved these changes

@Meilin-Lyu Meilin-Lyu Awaiting requested review from Meilin-Lyu

@QuocTrungTran QuocTrungTran Awaiting requested review from QuocTrungTran

@Kii-26 Kii-26 Awaiting requested review from Kii-26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@c25vdw @kdvuong @zhpeng811