Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BATIAI-2314: Configure deny by default for the shared ALB #138

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

bushong1
Copy link
Contributor

@bushong1 bushong1 commented Feb 13, 2024

Fixes Issue: BATIAI-2314

Description:

Security Impact Analysis Questionnaire

Submitter Checklist

  • Is there an impact on Auditing and Logging procedures or capabilities?
  • Is there an impact on Authentication procedures or capabilities?
  • Is there an impact on Authorization procedures or capabilities?
  • Is there an impact on Communication Security procedures or capabilities?
  • Configures a deny-by-default stance for our Public load balancers until an engineer explicitly states what domains are valid.
  • Is there an impact on Cryptography procedures or capabilities?
  • Is there an impact on Sensitive Data procedures or capabilities?
  • Is there an impact on any other security-related procedures or capabilities?
  • No security impacts identified.

Security Risks Identified - For any applicable items on the "Submitter Checklist," describe the impact of the change and any implemented mitigations.

@bushong1 bushong1 self-assigned this Feb 13, 2024
@bushong1 bushong1 requested a review from a team February 13, 2024 14:23
@robo-gotham
Copy link

robo-gotham commented Feb 13, 2024

Snyk Scanning for Commit: 1a3f8be

Snyk Infrastructure as Code

  • Snyk testing Infrastructure as Code configuration issues.
    ✔ Test completed.

Issues
No vulnerable paths were found!


Test Summary

Organization: batcave-ispg
Project name: CMS-Enterprise/batcave-tf-cluster

✔ Files without issues: 10
✗ Files with issues: 0
Ignored issues: 0
Total issues: 0 [ 0 critical, 0 high, 0 medium, 0 low ]


Report Complete

Your test results are available at: https://snyk.io/org/batcave-ispg/projects
under the name: CMS-Enterprise/batcave-tf-cluster

Copy link

@jonos-cms jonos-cms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I did a screenshare review with the purple team, and we collectively like this solution. Thank you for keeping the response generic.

@bushong1 bushong1 merged commit c4baffb into main Feb 13, 2024
1 check passed
@bushong1 bushong1 deleted the BATIAI-2314-deny-public-by-default branch February 13, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants