[AB2D-6147] increase ab2d-events-client coverage
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Jun 26, 2024
| @@ -121,7 +121,7 @@ public boolean equals(final Object o) { | |||
| if (otherTimeOfEvent != null) { | |||
| return false; | |||
| } | |||
| } else if (thisTimeOfEvent.toEpochSecond() != otherTimeOfEvent.toEpochSecond()) { | |||
| } else if (otherTimeOfEvent == null || thisTimeOfEvent.toEpochSecond() != otherTimeOfEvent.toEpochSecond()) { | |||
There was a problem hiding this comment.
I found this missing null check when writing the tests
There was a problem hiding this comment.
Do you plan to increase library version? may be later?
There was a problem hiding this comment.
Oh, thanks for catching that @smirnovaae! I forgot that part. I'll do it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6147
🛠 Changes
A very long and repetitious PR for testing
LoggableEvent. 80% of the diff is testing the extremely longequalsfunction, in such a way that hits every single possible case. While doing this I hit a null pointer exception (on the date handling), so I added a line of code to fix that.ℹ️ Context
This is a part of my journey towards 90% code coverage