Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-6997: PR Templates - Security Section #169

Merged
merged 4 commits into from
May 11, 2023

Conversation

gfreeman-navapbc
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-6997

🛠 Changes

Adds standard security section to pull request template.

Copy link

@bhodges-navapbc bhodges-navapbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Template security implications section updates look proper.

@gfreeman-navapbc gfreeman-navapbc merged commit 159f457 into master May 11, 2023
1 check passed
@gfreeman-navapbc gfreeman-navapbc deleted the gfreeman-BCDA-6997-pull-request-template branch May 11, 2023 19:58
gsf added a commit that referenced this pull request May 12, 2023
## 🎫 Ticket

https://jira.cms.gov/browse/PLT-77

## 🛠 Changes

Shortened security implications section in PR template to match
standard.

## ℹ️ Context for reviewers

Addendum to #169.

## ✅ Acceptance Validation

Final wording checked with @bhodges-navapbc.

## 🔒 Security Implications

- [ ] This PR adds a new software dependency or dependencies.
- [ ] This PR modifies or invalidates one or more of our security
controls.
- [ ] This PR stores or transmits data that was not stored or
transmitted before.
- [ ] This PR requires additional review of its security implications
for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username:
StewGoin) as a reviewer and do not merge this PR without his approval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants