BCDA-7971: Update curl commands with double quotes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature updates all curl command snippets that have single quotes to double quotes in order for them to run properly on Windows and UNIX based systems.
austincanada
requested review from
alex-dzeda,
laurenkrugen-navapbc,
kyeah and
greg-pf
laurenkrugen-navapbc
approved these changes
Apr 10, 2024
greg-pf
approved these changes
Apr 10, 2024
| @@ -20,14 +20,14 @@ <h2> | |||
| </tr> | |||
| <tr> | |||
| <td> | |||
| <pre><code>curl -X GET 'https://sandbox.bcda.cms.gov/api/v2/Group/all/$export' \ | |||
| <pre><code>curl -X GET "https://sandbox.bcda.cms.gov/api/v2/Group/all/$export" \ | |||
There was a problem hiding this comment.
Maybe we can sneak in highlighting of v2?
Suggested change
| <pre><code>curl -X GET "https://sandbox.bcda.cms.gov/api/v2/Group/all/$export" \ | |
| <pre><code>curl -X GET "https://sandbox.bcda.cms.gov/api/<span style="background: yellow">v2</span>/Group/all/$export" \ |
There was a problem hiding this comment.
We can add those to either one of the static site tickets for next sprint, if there needs to be accessibility checks for it.
| @@ -20,14 +20,14 @@ <h2> | |||
| </tr> | |||
| <tr> | |||
| <td> | |||
| <pre><code>curl -X GET 'https://api.bcda.cms.gov/api/v2/Group/all/$export' \ | |||
| <pre><code>curl -X GET "https://api.bcda.cms.gov/api/v2/Group/all/$export" \ | |||
There was a problem hiding this comment.
Same comment on highlighting v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature updates all curl command snippets that have single quotes to double quotes in order for them to run properly on Windows and UNIX based systems.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-7971
🛠 Changes
Updated the
_includes/files that contained cURL snippets.ℹ️ Context for reviewers
N/A
✅ Acceptance Validation
Changes verified on local static site.
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.