HDSG-206: Allow for Review components without an edit link #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannaliebl
reviewed
Jul 10, 2018
| @@ -45,12 +59,10 @@ describe('Review', function() { | |||
|
|
|||
| expect($p.length).toBe(1); | |||
There was a problem hiding this comment.
To keep the style consistent in here, can you remove the $ from in front of the p as well?
There was a problem hiding this comment.
I think it was originally prefixed with $ because it was a Cheerio wrapper. In this test it is still a Cheerio wrapper, and it's still a pattern in tests in other components to prefix these Cheerio wrappers. (I took out Cheerio rendering in the others because it was unnecessary to go beyond shallow rendering to get access to our...aaaaand I just tried removing it in this test as well, and it worked, so I'll make it like the others.
hannaliebl
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In App3 there are
<Review>components that do not have an edit link for one reason or another. We don't need to recommend uneditable review sections as a pattern, but it would be handy for App3 if we didn't need to hack around this requirement to get the desired behavior.Changed
<Review>component will not render a<ReviewLink>if theeditHrefprop is not provided