Fix to include the theme - if present - into the docs.css for local devs #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwolfert
approved these changes
Oct 26, 2018
There was a problem hiding this comment.
Wow! Your solution so much simpler than I expected the solution to be. I tested that it doesn't throw errors when using yarn start when there are no themes present and that having a theme present doesn't result in changed styles unless one's using yarn start:theme. LGTM 👍
|
The tests are failing because they're not configured to run on other repositories, so I'm going to merge this despite the failing tests. I've run the tests locally, and they're fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
docs.scss now imports the theme's .scss file(s), when building with
yarn start:themeoryarn build:theme.Changed
Also, updated the yarn lockfile.