Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonarqube not scanning dpc-portal #2104

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented Mar 28, 2024

🎫 Ticket

https://jira.cms.gov/browse/DPC-3971

🛠 Changes

Reverted simplecov gem to 0.17

ℹ️ Context for reviewers

Sonarqube stopped processing portal code coverage on Mar 5; the day the rails upgrade was merged into master. As part of the upgrade simplecov was not pinned to 0.17. Simplecov 0.18+ breaking ci is a known issue.
There was comment (present in the other gemfiles) warning not to upgrade, but it was removed because for some reason, when I run bundle install after sshing into the docker container, it will fail if there are too many bytes in the Gemfile. I removed "extraneous" comments, which meant I missed this.

✅ Acceptance Validation

Ran the build and checked the coverage.

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@jdettmannnava jdettmannnava requested a review from a team March 29, 2024 17:13
@jdettmannnava jdettmannnava marked this pull request as ready for review March 29, 2024 17:14
Copy link
Contributor

@kyeah kyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note about bundle install breaking because the Gemfile is too long is 🙈 Thanks for the fix!

Copy link
Contributor

@MEspositoE14s MEspositoE14s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing how long that issue thread has gone on, I'm not entirely optimistic a fix is inbound anytime soon from the developer.

@jdettmannnava
Copy link
Contributor Author

The note about bundle install breaking because the Gemfile is too long is 🙈 Thanks for the fix!

The weird thing is it does not break when building the container, only when running inside the container.

@jdettmannnava jdettmannnava merged commit c8fe913 into master Mar 29, 2024
4 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-3971-portal-sonarqube branch March 29, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants