Remove Bootstrap: We are not using it #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobison-usds
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We don't use this so let's prune it.
What Changed
Remove bootstrap gem.
Choices Made
Unnecessary. I did a quick click-through locally to confirm no UI changes. We never included the bootstrap assets in the app/assets dir so never even loaded them.
Tickets closed:
Give a list of tickets closed in this PR.
Future Work
List any additional tickets that have either been created due to work in this PR, or existing tickets that expand upon the feature or provide additional fixes.
Checklist
make ci-app(app change) andmake ci-web(website change)