Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Google analytics script into app script #1991

Closed
4 tasks
mgwalker opened this issue Jan 3, 2020 · 0 comments · Fixed by #2001
Closed
4 tasks

Move Google analytics script into app script #1991

mgwalker opened this issue Jan 3, 2020 · 0 comments · Fixed by #2001
Assignees
Labels
Development Issues for the dev team resolve

Comments

@mgwalker
Copy link
Contributor

mgwalker commented Jan 3, 2020

Currently the Google analytics script is the only inline script in our app, and that's causing our Mozilla Observatory score to be a B instead of an A. It's a minor thing, but we can fix it!

This task is done when...

  • the Google analytics bootstrap code is moved from index.html to app.js (this will also remove it from dev, which is probably a good thing)
  • after the new app.js is deployed to production, AWS is updated
  • the staging and production Lambda functions are updated to remove inline-unsafe from the script-src section of the Content-Security-Policy header
  • new versions of the staging and production functions are deployed
  • the staging and production CloudFront distributions are updated with the new Lambda functions' ARNs (CloudFront -> Edit distribution -> Behaviors -> update each existing behavior)
@mgwalker mgwalker added the Development Issues for the dev team resolve label Jan 3, 2020
@mgwalker mgwalker self-assigned this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development Issues for the dev team resolve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant