Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup and rearrangement #2001

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Some cleanup and rearrangement #2001

merged 3 commits into from
Jan 10, 2020

Conversation

mgwalker
Copy link
Contributor

@mgwalker mgwalker commented Jan 8, 2020

This pull request changes...

This pull request is ready to merge when...

  • Tests have been updated (and all tests are passing)
  • This code has been reviewed by someone other than the original author
  • The change has been documented
  • Changelog is updated as appropriate

@cms-eapd-bot
Copy link

cms-eapd-bot commented Jan 8, 2020

This deploy was cleaned up.

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #2001 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2001      +/-   ##
==========================================
+ Coverage   91.97%   92.06%   +0.08%     
==========================================
  Files         209      209              
  Lines        4075     4070       -5     
  Branches      603      599       -4     
==========================================
- Hits         3748     3747       -1     
+ Misses        306      303       -3     
+ Partials       21       20       -1
Impacted Files Coverage Δ
web/src/components/Wrapper.js 100% <100%> (+33.33%) ⬆️
web/src/components/App.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55932f3...42c777c. Read the comment docs.

Copy link
Contributor

@hbillings hbillings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love deleting things! Deleting things is my favorite!

@mgwalker mgwalker merged commit 57f3de1 into master Jan 10, 2020
@mgwalker mgwalker deleted the mgwalker/1990-1991-cleanup branch January 10, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Google analytics script into app script [Tech debt] Remove tota11y
4 participants