Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPPSF-5596 - Github actions #75

Merged
merged 7 commits into from
Jun 17, 2020

Conversation

bijujoseph
Copy link
Member

We are moving towards Github actions for build/deployment on library projects.

The current files will do the following:

when a PR is raised, it will run the build run the linters etc.
when a push to master branch occur, it will create a "DRAFT" release page
when "pre-release" occur, it will publish to npmjs.

Copy link
Contributor

@jonalarson jonalarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll work with Jay to get this fine tuned.

@jonalarson jonalarson self-requested a review June 17, 2020 16:32
Copy link
Contributor

@jonalarson jonalarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and removed the Travis CI webhook.

Copy link

@jeremy-page jeremy-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend to take out synk?
I don't see information on this change in either of the JIRA tickets referenced, otherwise this looks great!

@github-actions
Copy link

github-actions bot commented Jun 17, 2020

File Coverage Lines Branches
All files 83% 96% 71%
file-uploader-util.js 81% 94% 68%
file-uploader.js 93% 100% 86%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against e31d019

@jonalarson jonalarson merged commit 0f5e702 into develop Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants