Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent usage of underscores and dashes in layer Share link identifier #105

Open
rsargent opened this issue May 22, 2020 · 1 comment
Open

Inconsistent usage of underscores and dashes in layer Share link identifier #105

rsargent opened this issue May 22, 2020 · 1 comment
Assignees
@rsargent @arwright @pdille
Labels
low-priority need-discussion

Comments

@rsargent
Copy link
Member

Almost all Share link identifiers use underscores to separate tokens, but handful of layers use dashes, like "2019-nCOV_infection_confirmed_cases_bubble"

Going to earthtime.org and viewing the layer and clicking share to create a share link, the share link has the dash converted to an underscore:

https://earthtime.org/explore#v=-2.28999,0,0.489,latLng&t=1.91&ps=50&l=bdrk,2019_nCOV_infection_confirmed_cases_bubble&bt=20200120&et=20200530&startDwell=0&endDwell=0

In moving to the layer database, could we disallow dashes in the layer database, and convert them to underscores on the way in when reading from legacy google sheets?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsargent rsargent

@arwright arwright

@pdille pdille

Labels
low-priority need-discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rsargent @arwright @pdille