Add compile-time error for unsupported AST node types (RedisGraph#944)

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
CMU-SPEED · Feb 23, 2020 · 4db0526 · 4db0526
1 parent f31a74c
commit 4db0526
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/ast/ast_build_ar_exp.c b/src/ast/ast_build_ar_exp.c
@@ -441,8 +441,11 @@ static AR_ExpNode *_AR_EXP_FromExpression(const cypher_astnode_t *expr) {
 		   CYPHER_AST_PATTERN_COMPREHENSION
 		   CYPHER_AST_REDUCE
 		*/
-		printf("Encountered unhandled type '%s'\n", cypher_astnode_typestr(type));
-		assert(false);
+		const char *type_str = cypher_astnode_typestr(type);
+		char *error;
+		asprintf(&error, "RedisGraph does not currently support the type '%s'", type_str);
+		QueryCtx_SetError(error);
+		return AR_EXP_NewConstOperandNode(SI_NullVal());
 	}
 
 	assert(false);