Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decode_tx code? Or approach #26

Open
jotapea opened this issue Jan 20, 2024 · 1 comment
Open

Update decode_tx code? Or approach #26

jotapea opened this issue Jan 20, 2024 · 1 comment

Comments

@jotapea
Copy link
Collaborator

jotapea commented Jan 20, 2024

The source for decode_tx is the work by @Jpja (which he made the initial contribution):

https://github.com/Jpja/Electrum-Counterparty/blob/master/decode_tx.html

This is an html file, but xcp.dev needs it to be a JavaScript module.

This means that updates cannot be git-native cherry picked, thus breaking attributions (265900a, 9d35d0f).

So, instead of continuing with the copy-paste, lets discuss what we can do... Or document that is ok to continue in the unfortunately "un-attributable" way.

@jotapea
Copy link
Collaborator Author

jotapea commented Jan 20, 2024

Looking at this, and is code I want to get updated... AND it is already a module! So we might already be half way there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant