Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and verify scripts #21

Merged
merged 8 commits into from
Nov 3, 2020
Merged

Cleanup and verify scripts #21

merged 8 commits into from
Nov 3, 2020

Conversation

BryanCutler
Copy link
Member

@BryanCutler BryanCutler commented Nov 2, 2020

Moved all notebooks to scripts/

Fixed directory spelling of human_labels_audited

Replaced Label_Stats with Label_Stats_Fred.ipynb

Ran all scripts and notebooks and fixed any data file locations and made sure script ran

Fixes #18

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

]
},
{
"ename": "ZeroDivisionError",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmh4321 I get a div by 0 error when I run this notebook, can you check it out and see if you get the same?

@BryanCutler
Copy link
Member Author

@kmh4321 and @xuhdev , do we still need apply_sentence_correction.ipynb, sentence_correction_preprocessing.ipynb and token_correction_preprocessing.ipynb or can we archive them?

@xuhdev
Copy link
Collaborator

xuhdev commented Nov 2, 2020

apply_sentence_correction.ipynb is already in download_and_correct_corpus.py, sentence_correction_preprocessing.ipynb is only supposed to be used to generate the correction files. I'm not sure what token_correction_preprocessing.ipynb is for

@BryanCutler
Copy link
Member Author

Ok I'll archive apply_sentence_correction.ipynb since I'm sure that one has been ported, but leave the other 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verfiy scripts and notebooks
2 participants