Added styling enchancements to SpanArray text highlighting and rendering #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed javascript rendering engine with new styling
…PokkeFe/text-extensions-for-pandas into issue-201-spanarray-visual-enhancements
…eritance, and organized JS code.
frreiss
requested changes
Jun 17, 2021
|
Thanks for the updates, @PokkeFe. I think this set of changes is in good enough state to merge into master. One remaining issue that we should address ASAP in a follow-on PR: Cell 17 of our intro notebook throws an exception after these changes, because displaying multiple documents is not currently implemented. It would be better to generate an HTML error message (or generate an HTML warning followed by a display of the first document), so that this example notebook runs all the way to the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted SpanArray HTML generator to load scripts and style sheets from a dedicated resource module. Integrates base JavaScript for future dynamic behavior. Added new styles for nested and compound highlight regions.
Related to issue #201