Remove version check from workaround for Pandas #42430 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR, as this issue is blocking our CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion around pandas-dev/pandas#42430 is taking longer than expected. Pandas has released a 1.3.1 release without a fix for this issue. From the direction the discussion is taking, it looks like further performance related changes are likely to introduce similar breakage in the future, even after this issue is patched.
This PR removes the Pandas version check from the workaround from this issue. That way we won't be broken if Pandas decides to put the offending performance code into another future release. Due to the other checks that are still done, the workaround is still only activated in a narrow set of circumstances even after this change.