Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to support a BSD or MIT license #6

Open
rob-p opened this issue Jul 16, 2015 · 3 comments
Open

Figure out how to support a BSD or MIT license #6

rob-p opened this issue Jul 16, 2015 · 3 comments

Comments

@rob-p
Copy link
Contributor

rob-p commented Jul 16, 2015

Currently this is not possible as we rely on Jellyfish for the memory-efficient hash, parallel read parser, and basic k-mer operations. The read parser and (with some trouble) k-mer operations could be replaced with other alternatives or re-implemented. However, there's not a clear alternative for the hash right now, of which I know, that doesn't adversely affect either the memory consumption or speed.

@rob-p
Copy link
Contributor Author

rob-p commented Jan 17, 2016

Related to this issue, using the Jellyfish hash instead of the google hash makes loading the index considerably faster, and reduces the memory usage by 30-40%. However, it also increases the runtime by 30-40%. We should figure out what the right design decision is here.

@rob-p
Copy link
Contributor Author

rob-p commented Jul 14, 2016

The jellyfish parser can easily be replaced with FQFeeder --- this switch has already been made in the develop branch of salmon. The Jellyfish hash has also become a low priority because the minimum perfect hash option (based on BBHash and BooM) provides essentially the same benefit. So now, an equally efficient implementation of the k-mer operations exposed by Jellyfish are the only sticking point.

@robymetallo
Copy link

Hi Rob,
It looks like S. Vigna recently updated sux license vigna/sux@9faa343 to include the GCC Runtime Library Exception.
I believe this should be enough to allow re-licensing RapMap under a more permissive license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants