Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_atom_type.display_colour typo fix #381

Closed
wants to merge 1 commit into from

Conversation

rowlesmr
Copy link
Collaborator

@rowlesmr rowlesmr commented May 7, 2023

Changed colour_rgb to colour_RGB.

Everything else uses uppercase RGB.

@jamesrhester
Copy link
Contributor

This is perhaps unexpected, but our dictionary style guide points 4.3.1 and 5.1 explicitly specify all lowercase for save frame headings, and therefore by extension references to save frame headings.

Interestingly, all checks passed indicating that these particular rules are not checked by the style checker. I should fix that.

If you think this style could be improved, please raise an issue in the comcifs.github.io repository.

@jamesrhester
Copy link
Contributor

And yes, I realise that our imported save frames don't yet conform to the style rules. I'll add it to the list of issues.

@rowlesmr
Copy link
Collaborator Author

so (for example) save_pd_pref_orient_March_Dollase.diffractogram_block_id should be save_pd_pref_orient_march_dollase.diffractogram_block_id?

brb changing the pd dic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants