Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DICTIONARY_AUTHOR #408

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

rowlesmr
Copy link
Collaborator

@rowlesmr rowlesmr commented Jun 2, 2023

Will close #377.

Added the ability to record authors of a dictionary. Does there also need to be a DICTIONARY_AUTHOR_ROLES category? I think that may overcomplicate things, but it's an option.

ddl.dic Outdated Show resolved Hide resolved
ddl.dic Outdated Show resolved Hide resolved
Copy link
Collaborator

@vaitkus vaitkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the data item for an email address. However, I would like to go back to my previous question -- do we really need data items like address, phone number and fax? These may be useful during the CIF/paper publication process, but not that much in a DDL dictionary which is processed and distributed in a quite different way.

I suggest that we add the minimal useful set of data items for now such as name, email, orcid. The category can always be extended in the future if needed, but I really strongly doubt if we will ever need the fax field.

ddl.dic Outdated Show resolved Hide resolved
… in this dictionary

Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
@rowlesmr
Copy link
Collaborator Author

rowlesmr commented Jun 4, 2023

I think I've sent 2 faxes in my life. Both to renew my radiation licence; they accept emails now.

.

Name, email, and orcid are a minimal set; I was just being conservative in what I wrote by copying what we already had. I'm not phased if the others go.

@jamesrhester
Copy link
Contributor

Agree that minimal information is required here: just name, email, orcid_id.

@jamesrhester jamesrhester merged commit ff0d1de into COMCIFS:master Jun 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a dictionary_author category
3 participants