Describe primitive data items #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrhester
approved these changes
Jun 30, 2023
|
I think related items if they are links between categories are just assigned, but if they are SUs then they could be anything. So the primitive/non-primitive distinction doesn't apply neatly. |
Ok, we can update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewords some of the definitions as discussed in #437.
Specifically, it properly defines the primitive and non-primitive data items, and explicitly specifies that Definition methods should not be used on primitive items.
I was not sure if
Relateditems should be considered primitive or non-primitive. I guess they should be handled in the same way assAssignedvalues (primitive/non-primitive depending on the context).