Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter CELL-related saveframes from Recorded to Derived #441

Merged

Conversation

rowlesmr
Copy link
Collaborator

@rowlesmr rowlesmr commented Jul 1, 2023

will close #439

With moving CELL from EXPTL to DIFFRN, the related parameters should no longer be Recorded.

@jamesrhester
Copy link
Contributor

I don't think the move between categories of itself changes the _type.source, rather it is whether or not the values can be derived from other quantities that have data names defined. I suspect the original classification of Recorded might have been a leftover from the days when reflections were measured separately on a point detector, from which cell parameters where calculated and then used to position the gonio for each hkl. The items going into that cell parameter calculation were not necessarily captured by CIF. Anyway, happy for these to be derived, as you could argue that the contributing reflections are listed in DIFFRN_ORIENT_REFLN.

As per discussion in COMCIFS#434.
@jamesrhester jamesrhester merged commit 3b0d6e8 into COMCIFS:master Jul 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CELL-related saveframes in templ_attr need updating
2 participants