Rename the 'photons per second' unit to 'photons_per_second' #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the first official DDLm version of cif_img will be based on 1.8.8, I think it makes sense for this change to be in place prior to that version being generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #303.
The 'photons per second' units were renamed to 'photons_per_second' in the upcoming version 1.8.8 of the
cif_img.dicdictionary [1] so the same change can be reflected in DDLm as well.Although it is unlikely that the units will change again, we might want to wait until the release of version 1.8.8 just to be safe before merging this PR.
[1] https://github.com/yayahjb/cbf_imgcif_dictionary/tree/main