New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _definition.update to mandatory category attributes #493

Merged

jamesrhester merged 1 commit into COMCIFS:master from vaitkus:make-definition-update-mandatory-for-categories

May 20, 2024

Collaborator

vaitkus commented May 17, 2024

This PR adds _definition.update to the list of attributes mandatory for the 'Category' scope.

My two arguments in favour of this:

The _definition.update is already mandatory in the 'Item' scope.
Category definitions may also contain quite important information (e.g. key item declarations) so I think it would be useful to formally track this.


          Add _definition.update to the list of attributes that are mandatory i…

bcdfc0c

…n the

'Category' scope.

jamesrhester approved these changes

View reviewed changes

jamesrhester merged commit 79b5c18 into COMCIFS:master

3 checks passed

vaitkus deleted the make-definition-update-mandatory-for-categories branch

May 20, 2024 07:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment