Compatibility issue: Ruby 3 keyword arguments for Request constructor

[andreihelo]

Description

I am running into the following issue when trying to upgrade our app to Ruby 3.

ArgumentError:
  wrong number of arguments (given 1, expected 0)
# .../bundler/gems/crefo-b950bca2ae6e/lib/crefo/service/request.rb:8:in `initialize'
# .../bundler/gems/crefo-b950bca2ae6e/lib/crefo/service.rb:15:in `new'
# .../bundler/gems/crefo-b950bca2ae6e/lib/crefo/service.rb:15:in `process'

Fix

The fix is very simple in fact. An explicit keyword arguments delegation in lib/crefo/service.rb:15

require 'crefo/service/request'
require 'crefo/service/response'

module Crefo
  class Service
    ...

    def process
      begin
        url = Crefo.config.endpoint
        request = self.class::Request.new(**options)
        ...

[lagr]

@andreihelo Thank you for raising the issue and adding a proposed fix in the same go! I think the best way to proceed is for us to migrate the CI to GitHub Actions and bump the supported Ruby version to 3.0+ and to apply your fix at the same time.

[lagr]

Solved through #8