Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly link to Light/Dark image #32

Closed
loreanvictor opened this issue Jun 22, 2020 · 2 comments
Closed

Correctly link to Light/Dark image #32

loreanvictor opened this issue Jun 22, 2020 · 2 comments
Labels
bug Something isn't working minor This is a minor issue.

Comments

@loreanvictor
Copy link
Contributor

Currently the dark and light images in the DarkLight component are not ordered properly, as a result opening the image link will get weird results (opening the dark-mode image when in light mode and vice-versa).

It should be fixable by simply adding a higher z-index property to the visible div.

CONNECT-platform/coding-blog#19
@loreanvictor loreanvictor added bug Something isn't working minor This is a minor issue. labels Jun 22, 2020
@TysonMN
Copy link
Contributor

TysonMN commented Jun 23, 2020

There is similar but different behavior with coding-blog-boilerplate.

The banner image on the main page correctly varies based on light vs dark mode. However, for both modes, the link obtained when selecting "Copy image address" is http://localhost:3000/coding-blog-boilerplate/img/cb-banner-dark.svg.

loreanvictor added a commit that referenced this issue Jun 23, 2020
@loreanvictor
fix #33, #32
1e59363
@loreanvictor
Copy link
Contributor Author

deployed via @codedoc/core@0.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working minor This is a minor issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loreanvictor @TysonMN