Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process the time in a more fine-grained manner #134

Closed
KimballCai opened this issue May 8, 2023 · 2 comments
Closed

process the time in a more fine-grained manner #134

KimballCai opened this issue May 8, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@KimballCai
Copy link
Contributor

we can support the time in the "%d/%m/%Y" format, and we need to support a more fine-grained format, i.e., "%d/%m/%Y %H:%M:%S"

@KimballCai KimballCai added the enhancement New feature or request label May 8, 2023
@hugy718
Copy link
Collaborator

hugy718 commented May 8, 2023

I have looked into the current implementations on age selection. Actually they are using a date time object to calculate the difference on a given time unit. But action time input are stored as day since epoch in COOL. That prevents us from moving to hours, minutes and seconds.

The fix is that we switch the action time integer from days since epoch to seconds since epoch and update the conversions and diff calculations for age.

@hugy718
Copy link
Collaborator

hugy718 commented May 8, 2023

Support for more formats of action time can be supported by extension of ActionTimeIntConverter interface implementing custom conversion to an integer representing seconds since epoch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants