Completed #10
Open
Completed #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-yp
reviewed
Jul 15, 2022
| @@ -1,10 +1,7 @@ | |||
| <template> | |||
| <aside class="mx-auto flex justify-between mt-24 px-4"> | |||
| <label for="add task" class="flex-1"> | |||
| <input | |||
| type="text" | |||
| name="add task" | |||
There was a problem hiding this comment.
name attribute cannot have spaces in between
| " | ||
| placeholder="Enter Task" | ||
| /> | ||
| " v-model.trim="newTask" placeholder="Enter Task" /> |
| if (token === null && path === '/'){ | ||
| context.redirect('login/'); | ||
| } | ||
| else if(token != null && path != '/'){ |
pages/login/index.vue
Outdated
|
|
||
| const validateField = () => { | ||
| if (state.username === '' || state.password === '') { | ||
| $toast.error('Please fill all the fields correctly.') |
There was a problem hiding this comment.
Provide feedback as to what the error is ie -> username/password cannot be empty
pages/index.vue
Outdated
| }) | ||
| .then(() => { | ||
| this.$toast.success('Todo deleted successfully!') | ||
| this.$router.go() |
There was a problem hiding this comment.
Think of how you can delete the task and prevent reloading the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.