Made Changes Required For CSOC Vue Tasks #8
Conversation
There was a problem hiding this comment.
Hi @Samar1110! Overall a nice PR. The application is working fine and great use of toast. However, I do not see the deploy link in the issue description.
Key takeaways:
- Always make a PR from a feature branch.
- There was a task for UI improvement but I do not see any new features added.
- Noticed some console errors while running the application. They appeared when the
logoutbutton was clicked. PTAL
| @@ -2,6 +2,7 @@ | |||
| <aside class="mx-auto flex justify-between mt-24 px-4"> | |||
| <label for="add task" class="flex-1"> | |||
| <input | |||
| v-model.trim="newTask" | |||
| // this.$router.go() | ||
| }) | ||
| .catch(() => { | ||
| this.$toast.error('Task not Added Succesfully') |
There was a problem hiding this comment.
A good error callback would be to ask the user to try again.
| const path = context.route.fullPath | ||
| const token = context.store.getters.token | ||
|
|
||
| const newLocal = token != null && path !== '/' |
There was a problem hiding this comment.
Use JS naming convention for naming a boolean variable.
| if (this.todos[_index].title === '') { | ||
| this.$toast.error('Enter a Task in the Edit part...') | ||
| return | ||
| } |
There was a problem hiding this comment.
A check could be added to make sure that the value of the todo title is changed and that it is not the same as the original one. This would prevent sending void calls to the backend.
| @@ -2,6 +2,7 @@ | |||
| "compilerOptions": { | |||
| "target": "ES2018", | |||
| "module": "ESNext", | |||
| "jsx": "react", | |||
|
Actually when I was deploying my site using pnpm run build it showed some error by which later on my site was not working, so i did not deployed it |
You should definitely give it another try. If you are still not able to do it, feel free to post the error log here or on the discord so that we can help. |
Name : Samar Singh Randhawa
Roll No : 21095101
auth_required.jsandno_auth_required.jsMy Github Repo - Repo_Link