API DepletionReader export to Matlab file #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 20, 2018 16:33
Use scipy.io.savemat to save material data and, optionally, metadata to a file that can be loaded into matlab. Supports the ability to deconvert variable names back into their original form, or a mixedCase style, MAT_fuel_ING_TOX or fuel_ingTox. The intent is to eventually integrate a CLI tool for converting.
DepletionReader.saveAsMatlab now respects the metadata flag, and converts accordingly
Tests cover options to save metadata or not and to reconvert variable names or not
drewejohnson
added
API - Compatible
added 3 commits
December 21, 2018 09:16
DanKotlyar
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizes
scipy.io.savematto take contents of the reader and export them to a binary.matfile. This can be loaded into MATLAB, and in many cases is faster and more successful than reading in the text file.The method supports converting variables back to their original SERPENT_STYLE names or not, and optionally saving metadata as well.
Added unit tests that cover three cases:
Reconvert variable names back and write metadata
Reconvert variable names but don't write metadata
Don't convert variable names but do write metadata
PR fits the project scope
Code to be committed is DRY and matches the code style of the project