API Zero-indexed universes on results reader #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change, as storage of homogenized universes has changed. The first burnup index is now 0, not 1. This move makes the universes zero-indexed, consistent with the python ecosystem and the rest of this package. Tests have been updated to reflect these changes. The initial value of burnup and days for problems with out burnup are now zero, rather than one.
drewejohnson
added
documentation
pythonicness
API - Incompatible
DanKotlyar
approved these changes
Mar 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #277 by starting burnup steps at 0 rather than 1. Similarly, for cases where there is no burnup, the values of burnup and days are set as 0, rather than one.
The former case, zero-indexing, make the getUniv method and the storing of universes more pythonic, as arrays, lists, tuples, etc. start at position 0 in python. This is also consistent with the branching reader
serpent-tools/serpentTools/parsers/branching.py
Line 114 in 1c730ef
This is a breaking change, as the storage of universes has been changed, and thus