Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Refactor Active Graph Id #233

Merged
merged 14 commits into from
Oct 26, 2023
Merged

Refactor Active Graph Id #233

merged 14 commits into from
Oct 26, 2023

Conversation

SharkmanZA
Copy link
Collaborator

No description provided.

@SharkmanZA SharkmanZA added type: refactor Refactoring scope: UI Related to the user interface labels Oct 7, 2023
@SharkmanZA SharkmanZA added this to the Project Day milestone Oct 7, 2023
@SharkmanZA SharkmanZA self-assigned this Oct 7, 2023
@SharkmanZA SharkmanZA closed this Oct 7, 2023
@SharkmanZA SharkmanZA reopened this Oct 7, 2023
@SharkmanZA
Copy link
Collaborator Author

We might need to add some script to load on the plugins correctly for blink and ripple as the tests dont have the fully loaded plugin file.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #233 (c758f31) into dev (280c027) will decrease coverage by 2.96%.
Report is 20 commits behind head on dev.
The diff coverage is 66.66%.

❗ Current head c758f31 differs from pull request most recent head 5b441b5. Consider uploading reports for the commit 5b441b5 to get more accurate results

@@            Coverage Diff             @@
##              dev     #233      +/-   ##
==========================================
- Coverage   71.22%   68.26%   -2.96%     
==========================================
  Files          45       45              
  Lines        2655     2682      +27     
  Branches      504      508       +4     
==========================================
- Hits         1891     1831      -60     
- Misses        634      722      +88     
+ Partials      130      129       -1     
Files Coverage Δ
src/electron/lib/cache/CacheManager.ts 15.95% <100.00%> (ø)
src/shared/ui/UIGraph.ts 71.05% <100.00%> (ø)
...rc/electron/lib/core-graph/CoreGraphInterpreter.ts 78.78% <0.00%> (-2.47%) ⬇️
src/frontend/lib/Project.ts 90.90% <80.00%> (-1.40%) ⬇️
src/electron/lib/core-graph/CoreGraph.ts 84.38% <66.66%> (-0.79%) ⬇️
src/electron/lib/core-graph/CoreGraphManager.ts 82.47% <70.00%> (-0.53%) ⬇️
src/frontend/lib/PanelNode.ts 88.50% <87.87%> (-6.74%) ⬇️
src/electron/lib/projects/ProjectManager.ts 68.00% <0.00%> (-5.92%) ⬇️
src/electron/lib/projects/CoreProject.ts 68.42% <11.11%> (-17.79%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SharkmanZA SharkmanZA linked an issue Oct 25, 2023 that may be closed by this pull request
1 task
@ArmandKrynauw ArmandKrynauw merged commit bfd6e22 into dev Oct 26, 2023
13 checks passed
@ArmandKrynauw ArmandKrynauw deleted the refactor/projects branch October 26, 2023 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: UI Related to the user interface type: refactor Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor active graph to work per project
2 participants