This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
Refactor assets to be linked to a project #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArmandKrynauw
suggested changes
Oct 20, 2023
src/frontend/ui/tiles/Assets.svelte
Outdated
Comment on lines
120
to
121
| let cacheIds = readable<string[]>([]); | ||
| $: cacheIds = projectsStore.getReactiveActiveProjectCacheIds(); |
There was a problem hiding this comment.
What is happening with this sequence of reactive statemnts here? Cuase I believe you can just use
let cacheIds = projectStore.getReactiveProjectCacheIds();There was a problem hiding this comment.
Skill issue rip. Will fix...
ArmandKrynauw
approved these changes
Oct 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.