Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backend/view my bookings functionality #55

Merged

Conversation

Rethakgetse-Manaka
Copy link
Contributor

Description

Fixed and refactored all Booking functions on the backend. All that is left for me to do is update the docs and do the unit tests. This PR is so that @KamogeloMoeketse can engage with the functions for integration.

Fixes # (issue)

Type of change

Booking functions refactored

Please delete options that are not relevant.

  • New feature - View bookings is a new feature (non-breaking change which adds functionality)
  • Breaking change - Requests sent in must be adapted (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Has not been tested yet

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (03c88a8) to head (2c69ff6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #55      +/-   ##
===========================================
+ Coverage    65.15%   72.88%   +7.72%     
===========================================
  Files            3        3              
  Lines          132      118      -14     
===========================================
  Hits            86       86              
+ Misses          43       29      -14     
  Partials         3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rethakgetse-Manaka Rethakgetse-Manaka marked this pull request as draft June 9, 2024 10:32
@Rethakgetse-Manaka Rethakgetse-Manaka marked this pull request as ready for review June 9, 2024 12:03
@Rethakgetse-Manaka Rethakgetse-Manaka merged commit aa08b35 into develop Jun 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants