Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: Add rail_api.py & rail_api_enum.py #144

Merged
merged 1 commit into from
Jun 29, 2023
Merged

module: Add rail_api.py & rail_api_enum.py #144

merged 1 commit into from
Jun 29, 2023

Conversation

chuanchan1116
Copy link
Contributor

@chuanchan1116 chuanchan1116 commented May 21, 2023 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Added python client for querying ticket fare for rail. This is aimed to integrate transport expense into the system

Other information

To use this module, one has to register OAUTH API key on https://tdx.transportdata.tw/ and export CLIENT_ID & CLIENT_SECRET to environment variable.

@chuanchan1116 chuanchan1116 force-pushed the dev/william/rail-api branch 5 times, most recently from 31b532e to 0f7cce1 Compare May 21, 2023 12:12
@chuanchan1116 chuanchan1116 marked this pull request as draft May 21, 2023 12:15
@chuanchan1116
Copy link
Contributor Author

Since I haven't done the auth part so testing will failed, changing this to draft first.

@chuanchan1116 chuanchan1116 force-pushed the dev/william/rail-api branch 4 times, most recently from 3456e8e to 4f6db55 Compare June 7, 2023 17:46
@chuanchan1116 chuanchan1116 force-pushed the dev/william/rail-api branch 10 times, most recently from 91c2952 to 78c7397 Compare June 21, 2023 14:19
@chuanchan1116
module: Add rail_api.py & rail_api_enum.py
cb96f1a 
Signed-off-by: William Tsai <williamtsai1111@gmail.com>
@chuanchan1116 chuanchan1116 marked this pull request as ready for review June 21, 2023 14:30
@toomore toomore merged commit 75d4cb3 into main Jun 29, 2023
6 checks passed
@toomore toomore deleted the dev/william/rail-api branch July 10, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toomore toomore toomore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chuanchan1116 @toomore