Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loading tags after init() #154

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Remove loading tags after init() #154

merged 1 commit into from
Jul 7, 2023

Conversation

orertrr
Copy link
Member

@orertrr orertrr commented Jul 7, 2023

執行完 init() 後拿掉篩選條件旁邊的 Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

當使用者沒有關注的議程時,在 /2023/talks/fav/my 頁面底下篩選條件旁的 Loading 不會自動消失

Issue Number: N/A

What is the new behavior?

  • 載入完關注的議程時,會拿掉篩選條件旁的 Loading

Other information

Signed-off-by: orertrr <orertrr6207@gmail.com>
@orertrr orertrr requested a review from toomore July 7, 2023 15:59
Copy link
Member

@toomore toomore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@toomore toomore merged commit cb14a60 into COSCUP:forms Jul 7, 2023
1 check passed
@orertrr orertrr deleted the forms branch August 22, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants