Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save password in client cookies #4

Closed
Alextopher opened this issue Jul 3, 2023 · 3 comments · Fixed by #6
Closed

Save password in client cookies #4

Alextopher opened this issue Jul 3, 2023 · 3 comments · Fixed by #6
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Alextopher
Copy link
Member

We have a tradeoff between security and convenience. Currently go-talks requires clients joining from outside trusted subsets to enter a password. This imposes an inconvenience and in return we get more access control.

Talks is able to store authentication status during a single session, this should be made persistent on the client side so a user should only ever have to enter the password once.

@Alextopher Alextopher added enhancement New feature or request good first issue Good for newcomers labels Jul 3, 2023
@shayanshabani
Copy link
Contributor

Would you please assign me?

@Alextopher
Copy link
Member Author

@shayanshabani are you a Clarkson student or do you use this software? What brings you to wanting to contribute here?

@shayanshabani
Copy link
Contributor

I found your issue on goodfirstissues, I am a computer engineering student currently taking a web programming course.
I opened this pr #6 , I hope this helps.

@Alextopher Alextopher linked a pull request Jul 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants