Feature/116 add if condition executor #138
Conversation
MaartendeKruijf
added
enhancement
MaartendeKruijf
force-pushed
the
feature/116-add-if-condition-executor
branch
2 times, most recently
from
064f1e8
to
ff78ac2
Compare
MaartendeKruijf
force-pushed
the
feature/116-add-if-condition-executor
branch
from
e52b4b0
to
9641597
Compare
| return &Executor{stix: stix} | ||
| } | ||
|
|
||
| type IExecuter interface { |
There was a problem hiding this comment.
Just for clarity - perhaps it would be clearer to rename this interface to something like IIfConditionExecuter?
There was a problem hiding this comment.
I tried to keep it short because it's already in the package condition
| } | ||
| } | ||
|
|
||
| return step.OnCompletion, false, nil |
There was a problem hiding this comment.
This is probably never invoked, right? I would believe that the "on completion" step handling should be performed at decomposer level
There was a problem hiding this comment.
This is invoked when on_true or on_false are not set but the condition is valid en evaluates to true or false respectively
| } | ||
| if branch { | ||
| return decomposer.ExecuteBranch(stepId, variables) | ||
| } |
There was a problem hiding this comment.
If on_completion is handled at decomposer level, then I think its invocation should be performed here
There was a problem hiding this comment.
We are not branching if the on_true or on_false are not taken but for consistency sake we return the onCompletionId
There was a problem hiding this comment.
Great that we have if condition logic. But I don't understand exactly how the on_completion case is handled. Could easily be that I am missing something but I don't see that it is executed?
Also, I think that the reportStepStart and reportStepEnd calls are still missing in the if step execution
MaartendeKruijf
force-pushed
the
feature/116-add-if-condition-executor
branch
from
9641597
to
5366135
Compare
MaartendeKruijf
force-pushed
the
feature/116-add-if-condition-executor
branch
from
638b755
to
7b24b84
Compare
No description provided.