Add docker registry URL to image name #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using fully qualified image names means podman also works as an alternative to docker. Docker implicitly pulls unqualified images from docker.io, while podman requires fully qualified image names by default.
|
@dengelt let met check it but nice catch thanks! |
MaartendeKruijf
approved these changes
Jul 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fully qualified image names means
podman also works as an alternative to
docker. Docker implicitly pulls unqualified
images from docker.io, while podman requires
fully qualified image names by default.
This change should not impact docker usage, but I have tested only with podman.