Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docs/18 docs update #20

Merged
merged 30 commits into from
Mar 15, 2024
Merged

Conversation

RabbITCybErSeC
Copy link
Collaborator

No description provided.

@MaartendeKruijf MaartendeKruijf force-pushed the feature/docs/18-docs-update branch 2 times, most recently from 5bd5f04 to a2c0403 Compare March 7, 2024 16:09
@hidde-jan hidde-jan force-pushed the feature/docs/18-docs-update branch from 7b81257 to 512b636 Compare March 8, 2024 13:55

```json
"target_definitions": {
"linux--b49069c2-0b69-4a46-8509-80196c4a9bf8": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux is not a valid target in soarca

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually use the type of targets anywhere, right? And linux is a target type in the spec.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No but this gives the impression it is possible which is not

docs/content/en/docs/core-components/modules.md Outdated Show resolved Hide resolved
docs/content/en/docs/about/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/executable-playbooks.md Outdated Show resolved Hide resolved

### If-condition, while-condition, and parallel steps

An `if-condition` step allows executing different branches depending on a specified condition. The step must specify an `on_true` field, which references the start of a branch of steps that should be executed if the condition evaluates to true. Optionally, the `if-condition` step can define an `on_false` field that defines an alternative branch that is executed if the condition evaluates to false. In each case, the specified branch keeps executing until it encounters an `end` step.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucamrgs and @MaartendeKruijf discussed this but this makes for difficult execution, which also makes execution paths a bit tricky we will take this up with the TC.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think understand your issue. It's that you need to keep track of the current branch and where it started. A brand-end step could then specify the head of the branch so it's simpler to move onto the next step on that level, right?

docs/content/en/docs/concepts/executable-playbooks.md Outdated Show resolved Hide resolved
@MaartendeKruijf MaartendeKruijf merged commit fad4656 into development Mar 15, 2024
9 checks passed
@MaartendeKruijf MaartendeKruijf deleted the feature/docs/18-docs-update branch March 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants